fix: DynamicVoiceChat deleting channel without checking if members are in there (#1395)

tj-wazei · surajkumar · web-flow · commit 03090447367a · 2026-01-26T14:34:08.000Z
Co-authored-by: Suraj Kumar &lt;sk96.uk@gmail.com&gt;
diff --git a/application/src/main/java/org/togetherjava/tjbot/features/voicechat/DynamicVoiceChat.java b/application/src/main/java/org/togetherjava/tjbot/features/voicechat/DynamicVoiceChat.java
@@ -81,6 +81,12 @@ private void handleVoiceChannelLeave(AudioChannelUnion channelLeft) {
         if (!eventHappenOnDynamicRootChannel(channelLeft)) {
             logger.debug("Event happened on left channel {}", channelLeft);
 
+            if (hasMembers(channelLeft)) {
+                logger.debug("Voice channel {} not empty, so not doing anything.",
+                        channelLeft.getName());
+                return;
+            }
+
             channelLeft.asVoiceChannel().getHistory().retrievePast(2).queue(messages -> {
                 if (messages.size() > 1) {
                     archiveDynamicVoiceChannel(channelLeft);
@@ -124,16 +130,13 @@ private void moveMember(Guild guild, Member member, AudioChannel channel) {
                             member.getNickname(), channel.getName(), error));
     }
 
+    private boolean hasMembers(AudioChannelUnion channel) {
+        return !channel.getMembers().isEmpty();
+    }
+
     private void archiveDynamicVoiceChannel(AudioChannelUnion channel) {
-        int memberCount = channel.getMembers().size();
         String channelName = channel.getName();
 
-        if (memberCount > 0) {
-            logger.debug("Voice channel {} not empty ({} members), so not removing.", channelName,
-                    memberCount);
-            return;
-        }
-
         Optional<Category> archiveCategoryOptional = channel.getGuild()
             .getCategoryCache()
             .stream()
