Line Sweep algorithm for range problems#4152
Closed
Ltwo3five wants to merge 2 commits intoTheAlgorithms:masterfrom
Closed
Line Sweep algorithm for range problems#4152Ltwo3five wants to merge 2 commits intoTheAlgorithms:masterfrom
Ltwo3five wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Contributor
Ltwo3five
commented
Apr 11, 2023
Ltwo3five
commented
- I have read CONTRIBUTING.md.
- This pull request is all my own work -- I have not plagiarized it.
- All filenames are in PascalCase.
- All functions and variable names follow Java naming conventions.
- All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
Ltwo3five
requested review from
debasishbsws,
siriak and
yanglbme
as code owners
siriak
requested changes
Apr 17, 2023
| * otherwise. | ||
| */ | ||
|
|
||
| public static boolean isOverlap(int[][] ranges,int maximum) { |
Member
There was a problem hiding this comment.
What is maximum? If it's the biggest point in ranges, it can be derived from ranges and doesn't need to be passed separately
Contributor
Author
There was a problem hiding this comment.
You are right. I will add logic to get the maximum value(Basically the largest end value in the array)
| /** Line Sweep algorithm can be used to solve range problems by first sorting the list of ranges | ||
| * by the start value of the range in non-decreasing order and doing a "sweep" through the number | ||
| * line(x-axis) by incrementing the start point by 1 and decrementing end point by -1 on the | ||
| * number line. https://www.topcoder.com/thrive/articles/Line%20Sweep%20Algorithms |
Member
There was a problem hiding this comment.
Please also add a link to Wikipedia
Contributor
Author
|
I created a feature branch and sent another pull request using that, and will reset my master branch to upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.