Experiment with disabling ASViewController background dealloc

mikezucc · mikezucc · commit 4e2b1706e3c0 · 2019-03-22T13:07:52.000-07:00
diff --git a/Podfile.lock b/Podfile.lock
@@ -52,4 +52,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: 445046ac151568c694ff286684322273f0b597d6
 
-COCOAPODS: 1.6.0
+COCOAPODS: 1.5.3
diff --git a/Schemas/configuration.json b/Schemas/configuration.json
@@ -26,7 +26,8 @@
                     "exp_dispatch_apply",
                     "exp_image_downloader_priority",
                     "exp_text_drawing",
-                    "exp_fix_range_controller"
+                    "exp_fix_range_controller",
+                    "exp_oom_bg_dealloc_disable"
                 ]
     		}
 		}
diff --git a/Source/ASExperimentalFeatures.h b/Source/ASExperimentalFeatures.h
@@ -32,6 +32,7 @@ typedef NS_OPTIONS(NSUInteger, ASExperimentalFeatures) {
   ASExperimentalImageDownloaderPriority = 1 << 11,          // exp_image_downloader_priority
   ASExperimentalTextDrawing = 1 << 12,                      // exp_text_drawing
   ASExperimentalFixRangeController = 1 << 13,               // exp_fix_range_controller
+  ASExperimentalOOMBackgroundDeallocDisable = 1 << 14,      // exp_oom_bg_dealloc_disable
   ASExperimentalFeatureAll = 0xFFFFFFFF
 };
 
diff --git a/Source/ASExperimentalFeatures.mm b/Source/ASExperimentalFeatures.mm
@@ -25,7 +25,8 @@
                                       @"exp_dispatch_apply",
                                       @"exp_image_downloader_priority",
                                       @"exp_text_drawing",
-                                      @"exp_fix_range_controller"]));
+                                      @"exp_fix_range_controller",
+                                      @"exp_oom_bg_dealloc_disable"]));
   if (flags == ASExperimentalFeatureAll) {
     return allNames;
   }
diff --git a/Source/ASViewController.mm b/Source/ASViewController.mm
@@ -15,6 +15,8 @@
 #import <AsyncDisplayKit/ASTraitCollection.h>
 #import <AsyncDisplayKit/ASRangeControllerUpdateRangeProtocol+Beta.h>
 #import <AsyncDisplayKit/ASInternalHelpers.h>
+#import <AsyncDisplayKit/ASConfigurationInternal.h>
+#import <AsyncDisplayKit/ASExperimentalFeatures.h>
 
 @implementation ASViewController
 {
@@ -98,6 +100,9 @@ - (void)_initializeInstance
 
 - (void)dealloc
 {
+  if (ASActivateExperimentalFeature(ASExperimentalOOMBackgroundDeallocDisable)) {
+    return;
+  }
   ASPerformBackgroundDeallocation(&_node);
 }
 
diff --git a/Tests/ASConfigurationTests.mm b/Tests/ASConfigurationTests.mm
@@ -31,7 +31,8 @@
   ASExperimentalDispatchApply,
   ASExperimentalImageDownloaderPriority,
   ASExperimentalTextDrawing,
-  ASExperimentalFixRangeController
+  ASExperimentalFixRangeController,
+  ASExperimentalOOMBackgroundDeallocDisable
 };
 
 @interface ASConfigurationTests : ASTestCase <ASConfigurationDelegate>
@@ -57,7 +58,8 @@ + (NSArray *)names {
     @"exp_dispatch_apply",
     @"exp_image_downloader_priority",
     @"exp_text_drawing",
-    @"exp_fix_range_controller"
+    @"exp_fix_range_controller",
+    @"exp_oom_bg_dealloc_disable"
   ];
 }
 

Original file line number	Diff line number	Diff line change
`@@ -52,4 +52,4 @@ SPEC CHECKSUMS:`
`52`	`52`
`53`	`53`	`PODFILE CHECKSUM: 445046ac151568c694ff286684322273f0b597d6`
`54`	`54`
`55`		`-COCOAPODS: 1.6.0`
	`55`	`+COCOAPODS: 1.5.3`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,8 @@`
`26`	`26`	`"exp_dispatch_apply",`
`27`	`27`	`"exp_image_downloader_priority",`
`28`	`28`	`"exp_text_drawing",`
`29`		`- "exp_fix_range_controller"`
	`29`	`+ "exp_fix_range_controller",`
	`30`	`+ "exp_oom_bg_dealloc_disable"`
`30`	`31`	`]`
`31`	`32`	`}`
`32`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@`
`15`	`15`	`#import <AsyncDisplayKit/ASTraitCollection.h>`
`16`	`16`	`#import <AsyncDisplayKit/ASRangeControllerUpdateRangeProtocol+Beta.h>`
`17`	`17`	`#import <AsyncDisplayKit/ASInternalHelpers.h>`
	`18`	`+#import <AsyncDisplayKit/ASConfigurationInternal.h>`
	`19`	`+#import <AsyncDisplayKit/ASExperimentalFeatures.h>`
`18`	`20`
`19`	`21`	`@implementation ASViewController`
`20`	`22`	`{`
`@@ -98,6 +100,9 @@ - (void)_initializeInstance`
`98`	`100`
`99`	`101`	`- (void)dealloc`
`100`	`102`	`{`
	`103`	`+ if (ASActivateExperimentalFeature(ASExperimentalOOMBackgroundDeallocDisable)) {`
	`104`	`+ return;`
	`105`	`+ }`
`101`	`106`	`ASPerformBackgroundDeallocation(&_node);`
`102`	`107`	`}`
`103`	`108`