[LIB-837] - add custom sockets functionality to the LIB.#228
Merged
opalczynski merged 32 commits intodevelopfrom Aug 24, 2016
Merged
[LIB-837] - add custom sockets functionality to the LIB.#228opalczynski merged 32 commits intodevelopfrom
opalczynski merged 32 commits intodevelopfrom
Conversation
…r file, add possibility to recheck and update custom socket; add possibility to remove endpoints and dependencies;
docs/source/custom_sockets.rst
Outdated
| Custom Sockets in Syncano | ||
| ========================= | ||
|
|
||
| ``Syncano`` provides possibility of creating the custom sockets. It means that there's a possibility |
Member
|
left a few comments, most of them are for docs though (maybe someone native could take a look at it and check for grammar? or if you want I can recheck it after it's fixed). Overall, I really like your approach, it's easy to understand and comprehensive. |
…s; correct ScriptDependency to handle ScriptEndpoint; make Script a model field in ScriptEndpoint; overall fixes;
| @@ -0,0 +1,239 @@ | |||
| .. _custom-sockets: | |||
Contributor
Author
There was a problem hiding this comment.
@lifcio We need help from native here ;)
Contributor
|
Will check soon with @devintyler, thx for the mention! |
opalczynski
changed the title
Contributor
Author
|
@zhebr Could you take a look? :) |
| Custom Sockets in Syncano | ||
| ========================= | ||
|
|
||
| ``Syncano`` gives its users the ability to create Custom Sockets. What this means is that users can define very specific |
Contributor
There was a problem hiding this comment.
I don't like the style. But if it's revised - I won't fight.
Contributor
|
Neat. Good reading. Small things to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing:
@23doors
It would be nice if you can take a look: