Conversation
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 38.47% 37.21% -1.27%
==========================================
Files 88 99 +11
Lines 2773 4109 +1336
Branches 6 6
==========================================
+ Hits 1067 1529 +462
- Misses 1706 2580 +874 |
mkucharz
requested changes
Oct 24, 2018
docs/docs/project/hosting.md
Outdated
|
|
||
| ## Socket mapping | ||
|
|
||
| Mapping is a configuration of hosting which gives us possibility bypass preflighted requests in CORS |
Member
There was a problem hiding this comment.
Where are the dots at the end of sentences?
Maybe something more like:
"Mapping is a configuration of hosting which gives you a possibility to expose sockets endpoints as a part of the hosting URL. It is also helping to avoid preflighted requests in CORS.
For example:
->
"
mkucharz
requested changes
Oct 25, 2018
docs/docs/project/hosting.md
Outdated
| ## Socket mapping | ||
|
|
||
| Mapping is a configuration of hosting which gives us possibility bypass preflighted requests in CORS | ||
| Mapping is a configuration of hosting which gives you a possibility to expose sockets endpoints as a part of the hosting URL. It is also helping to avoid preflighted requests in CORS. |
mkucharz
approved these changes
Oct 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.