Skip to content

feat: added support for catchall datatype: object, and added catchall_complete() so that one filter can do everything#1012

Merged
nonprofittechy merged 2 commits intoSuffolkLITLab:mainfrom
jpagh:main
Feb 17, 2026
Merged

feat: added support for catchall datatype: object, and added catchall_complete() so that one filter can do everything#1012
nonprofittechy merged 2 commits intoSuffolkLITLab:mainfrom
jpagh:main

Conversation

@jpagh
Copy link
Contributor

@jpagh jpagh commented Feb 16, 2026

  • Removed unused deps
  • Refactored catchall_options() to support catchall_datatype("object") by passing in the strings directly to docassemble rather than tupling them
  • Added catchall_complete() so that you don't have to use a bunch of separate filters if you don't want to, which can keep the template cleaner

… so that one filter can do everything

fix: corrected mypy types

fix: removed unused import to satisfy mypy

fix: black formatting on whole project

fix: removed unused imports

style: applied black
@jpagh
Copy link
Contributor Author

jpagh commented Feb 16, 2026

It's just black that's failing, and I can't figure out why when Github Actions runs black, it wants to make a change to sessions.py, but when I run it, I get this:

❯ python -m black .
All done! ✨ 🍰 ✨
10 files left unchanged.

EDIT: I had black v25, but there's a new v26 out that I didn't realize and it wanted to make new and interesting changes...

This PR also does way more than I was trying to make it do, because I ended up having to not just fix mypy type errors in my new code (which is cool), but then fix other files and stuff for unused imports, import errors, and black formatting for all of it. Sorry. My actual code changes are not that significant.

@BryceStevenWilley
Copy link
Contributor

I don't think you need to fix the unused imports for mypy CI to pass, just so you know.

The catchall_complete looks fine to me, but I'll let @nonprofittechy review it since he's more familiar with the code. The only thing I would consider asking for is a test for the catchall_option changes, but it doesn't look like we have one either, so no obligation there.

@nonprofittechy
Copy link
Member

nonprofittechy commented Feb 17, 2026

@BryceStevenWilley I can't spot the flaw in the branch protection rules, but I think something isn't quite right

Edit: OK I think it was "Restrict updates" causing the issue

@nonprofittechy nonprofittechy merged commit 1ee85a7 into SuffolkLITLab:main Feb 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants