Skip to content

#296 - Replacing window references with self to allow running in a WebWorker#468

Merged
dduponchel merged 3 commits intoStuk:masterfrom
Buslowicz:master
Nov 5, 2017
Merged

#296 - Replacing window references with self to allow running in a WebWorker#468
dduponchel merged 3 commits intoStuk:masterfrom
Buslowicz:master

Conversation

@Buslowicz
Copy link
Copy Markdown
Contributor

Fixing the issue preventing the use of jszip in a WebWorker.

Daniel Busłowicz and others added 3 commits October 15, 2017 14:40
@dduponchel
Copy link
Copy Markdown
Contributor

I'm ok with the change (thank you!), I just pushed a new commit to remove the changes in the dist/ folder.
The build is now KO in nodejs 0.10 and 0.12, likely because of Medium/phantomjs/issues/753.
I'll merge this one and fix the build in an other pull request.

@dduponchel dduponchel merged commit 6aa06da into Stuk:master Nov 5, 2017
@dduponchel dduponchel mentioned this pull request Nov 9, 2017
jmerdich pushed a commit to jmerdich/jszip that referenced this pull request Jan 6, 2019
… in a WebWorker (Stuk#468)

* Stuk#296 - Replacing `window` references with `self` to allow running in a WebWorker

* Stuk#296 - Adding `self` to global objects for linter

* Revert the dist/ folder

These files are only generated on new releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants