Fix ie11 memory leak#429
Conversation
|
I too had a memory leak problem with only IE11; when zipping a 12.6MB file my browser would allocate more than 1.3GB of memory, and the browser would hang. This was not the case in Edge and Chrome. After applying this patch, the memory leak was gone in IE11 and the browser could successfully zip. |
|
I think it comes from #357 (released in v3.1.3). I will check if the version 3.1.2 has the same issue. |
|
I confirmed it. As you said, there was no problem with version 3.1.2. |
|
I reproduced the issue on IE 11 and Edge. I found the issue on Microsoft bug tracker: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7115840/ I find your fix is a bit too broad:
|
This reverts e156d9c (which triggered the memory leak) and partially reverts 72467ef. Using the presence of `MSBlobBuilder` means we will get a different behavior (double the amount of memory needed) only of IE11/Edge, even after they fix the issue. It also means using feature detection to work around bugs.
|
I'll take the revert of #357, I'll update this pull request to change the behavior. |
3 participants
When IE 11 converts it to ZIP, it seems that it has not been released since it consumes a lot of memory.
This pull request implementing memory release.
Test file total size is 12.6 MB
Before: first, 92MB to 1.7GB, and not release memory.
After: fixed, There is no problem even if repeating.
If necessary, I will show sample code as well.