Skip to content

Feature: add top progress bar while changing route. - #138

Merged
Arifulislam5577 merged 5 commits into
StaticMania:mainfrom
shuvo-me:feature/add_nprogress
Feb 18, 2024
Merged

Feature: add top progress bar while changing route.#138
Arifulislam5577 merged 5 commits into
StaticMania:mainfrom
shuvo-me:feature/add_nprogress

Conversation

@shuvo-me

Copy link
Copy Markdown
Contributor

@vercel

vercel Bot commented Feb 18, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep-react ❌ Failed (Inspect) Feb 18, 2024 9:53am

@vercel

vercel Bot commented Feb 18, 2024

Copy link
Copy Markdown

@shuvo-me is attempting to deploy a commit to the StaticMania Team on Vercel.

A member of the Team first needs to authorize it.

@shuvo-me

Copy link
Copy Markdown
Contributor Author

@Arifulislam5577 vai you can check the pr. thanks

@Arifulislam5577

Copy link
Copy Markdown
Collaborator

Hi @shuvo-me,

Thank you for your contribution to our Keep React documentation! Adding a top progress bar while changing routes is indeed a great enhancement for improving user experience. This feature will provide visual feedback to users, letting them know that their action (such as clicking on a link) has been acknowledged and is being processed.

However, you've added the "next-nprogress-bar" package as a dependency, but we believe it should be included as a devDependency instead. Since this package does not directly affect our Keep React components, placing it in devDependencies would be more appropriate for our code structure. Could you please adjust this and commit it again? Remember that commit messages should start with a capital letter and end with a period.

We appreciate your effort in making our documentation more user-friendly. Your contribution aligns perfectly with our goal of continually improving the usability and accessibility of our platform.

Looking forward to your next contribution!

Best regards,
Md Ariful Islam.

Comment thread app/components/AppTopProgressBar.tsx Outdated
Comment thread app/layout.tsx Outdated
@shuvo-me

Copy link
Copy Markdown
Contributor Author

Hi @shuvo-me,

Thank you for your contribution to our Keep React documentation! Adding a top progress bar while changing routes is indeed a great enhancement for improving user experience. This feature will provide visual feedback to users, letting them know that their action (such as clicking on a link) has been acknowledged and is being processed.

However, you've added the "next-nprogress-bar" package as a dependency, but we believe it should be included as a devDependency instead. Since this package does not directly affect our Keep React components, placing it in devDependencies would be more appropriate for our code structure. Could you please adjust this and commit it again? Remember that commit messages should start with a capital letter and end with a period.

We appreciate your effort in making our documentation more user-friendly. Your contribution aligns perfectly with our goal of continually improving the usability and accessibility of our platform.

Looking forward to your next contribution!

Best regards, Md Ariful Islam.

Thanks @Arifulislam5577 vai. I love to contribute to this type of awesome project in my free time. Nice to meet you.

@Arifulislam5577

Copy link
Copy Markdown
Collaborator

Hi @shuvo-me,

Thank you for your contribution to our Keep React documentation! Adding a top progress bar while changing routes is indeed a great enhancement for improving user experience. This feature will provide visual feedback to users, letting them know that their action (such as clicking on a link) has been acknowledged and is being processed.

We've reviewed your changes, and everything looks perfect! Your attention to detail and prompt response are greatly appreciated.

The pull request has been merged successfully, and we're excited to see your next contribution. Keep up the fantastic work!

Best regards,
Md Ariful Islam

@Arifulislam5577
Arifulislam5577 merged commit c9271a8 into StaticMania:main Feb 18, 2024
Arifulislam5577 added a commit that referenced this pull request Feb 18, 2024
@Arifulislam5577

Copy link
Copy Markdown
Collaborator

Hi @shuvo-me vai please create a new pull request with the latest code in this feature so that I can add your in our contributor list. I forgot to add you in our contributor list.

@Arifulislam5577 Arifulislam5577 added the documentation Improvements or additions to documentation label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants