Swallow unhandled rejection explicitly in ajax transport when using fetch#4662
Open
benjamingr wants to merge 1 commit intoSignalR:mainfrom
Open
Swallow unhandled rejection explicitly in ajax transport when using fetch#4662benjamingr wants to merge 1 commit intoSignalR:mainfrom
benjamingr wants to merge 1 commit intoSignalR:mainfrom
Conversation
Author
|
piing |
eliassultan778
approved these changes
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At Excel Online we've noticed errors showing up in instrumentation when fetch fails to fetch when stopping a connection (e.g. on page unload).
This PR swallows that error explicitly instead of implicitly. Also good: actually handling the error would also meet our needs.
Cheers, love and thanks