Stop on existing #975
Open
Stop on existing #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi! Thanks for the PR. We do have a formatting requirement. If you could do those for your PRs, I'll do the review for them. This seems like a good feature, so thank you. |
Contributor
Author
|
Ok great, I' not sure how to interpret the checklist results (the Details are all empty errors). Was the only thing the spaces between assign/compares? (committed) |
I think you just have to run index e62c930..af38a9f 100644
--- a/bdfr/downloader.py
+++ b/bdfr/downloader.py
@@ -114,8 +114,8 @@ class RedditDownloader(RedditConnector):
if self.args.stop_on_exist and not submission.stickied:
self.existcount += 1
if self.existcount >= 5:
- logger.warning("Prevously-downloaded threshold met, exiting")
- exit(0)
+ logger.warning("Prevously-downloaded threshold met, exiting")
+ exit(0)
continue
elif not self.download_filter.check_resource(res):
logger.debug(f"Download filter removed {submission.id} file with URL {submission.url}")
@@ -162,7 +162,7 @@ class RedditDownloader(RedditConnector):
@staticmethod
def scan_existing_files(directory: Path) -> dict[str, Path]:
files = []
- for (dirpath, _dirnames, filenames) in os.walk(directory):
+ for dirpath, _dirnames, filenames in os.walk(directory):
files.extend([Path(dirpath, file) for file in filenames])
logger.info(f"Calculating hashes for {len(files)} files") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading content from specific sources, sorted by new, exit the script when 5+ already-downloaded items are encountered. Do not keep downloading past this point.
Does not apply pinned posts towards the "already downloaded" counter.
Warns if used without sorting by new.