Ensure that the data being read is actually large enough to have a debug directory entry parsed from it - #96
Merged
Conversation
…bug directory entry parsed from it
|
|
||
| int offset = 0; | ||
| while (offset < data.Length) | ||
| while (offset < data.Length && data.Length - offset >= 28) |
Contributor
Author
There was a problem hiding this comment.
Looking at ParseDebugDirectoryEntry, it seems to parse 6 Uint32s and 2 Uint16s, so I assume that you need data to be at least 28 bytes long for this to actually succeed
mnadareski
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For PE, no checks on the data size were performed to make sure that a debug directory entry could actually be parsed from the debug table, causing PE parsing to fail on some executables. In this specific case, the optionalheader has a debug table size of 1 byte, smaller than the 28 bytes needed to actually parse a debug directory entry.
Executable in question that this was failing on beforehand:
shuttle.zip
Comes from Space Shuttle Mission Simulator (not on redump yet)