Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Add a failing concurrency test #480

Open
roetlich wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a failing concurrency test #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 31 additions & 14 deletions tests/SqlStreamStore.AcceptanceTests/AcceptanceTests.AppendStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using Shouldly;
using SqlStreamStore.Streams;
using Xunit;
using System.Linq;

public partial class AcceptanceTests
{
Expand All @@ -28,7 +29,7 @@ await Store.AppendToStream(

[Fact, Trait("Category", "AppendStream")]
public async Task
When_append_stream_second_time_with_no_stream_expected_and_same_messages_then_should_then_should_be_idempotent()
When_append_stream_second_time_with_no_stream_expected_and_same_messages_then_should_be_idempotent()
{
// Idempotency
const string streamId = "stream-1";
Expand All @@ -42,7 +43,7 @@ await Store
}

[Fact, Trait("Category", "AppendStream")]
public async Task When_append_stream_second_time_with_no_stream_expected_and_same_messages_then_should_then_should_have_expected_result()
public async Task When_append_stream_second_time_with_no_stream_expected_and_same_messages_then_should_have_expected_result()
{
// Idempotency
const string streamId = "stream-1";
Expand Down Expand Up @@ -665,7 +666,7 @@ await Store
exception.ShouldBeOfType<WrongExpectedVersionException>(
ErrorMessages.AppendFailedWrongExpectedVersion(streamId, 10));
}

[Theory, Trait("Category", "AppendStream")]
[InlineData("stream/id")]
[InlineData("stream%id")]
Expand All @@ -676,7 +677,7 @@ public async Task When_append_to_stream_with_url_encodable_characters_and_expect
result.CurrentVersion.ShouldBe(2);
result.CurrentPosition.ShouldBeGreaterThanOrEqualTo(Fixture.MinPosition + 2L);
}

[Theory, Trait("Category", "AppendStream")]
[InlineData("stream/id")]
[InlineData("stream%id")]
Expand All @@ -699,7 +700,7 @@ public async Task When_append_to_stream_with_url_encodable_characters_and_expect
result.CurrentVersion.ShouldBe(2);
result.CurrentPosition.ShouldBeGreaterThanOrEqualTo(Fixture.MinPosition + 2L);
}

[Theory, Trait("Category", "AppendStream")]
[InlineData("stream/id")]
[InlineData("stream%id")]
Expand All @@ -713,40 +714,56 @@ public async Task When_append_to_stream_with_url_encodable_characters_and_expect
}

[Fact, Trait("Category", "AppendStream")]
public async Task When_append_stream_concurrently_with_no_stream_expected_and_same_messages_then_should_then_should_have_expected_result()
public async Task When_append_stream_concurrently_with_no_stream_expected_and_same_messages_then_should_have_expected_result()
{
// Idempotency
const string streamId = "stream-1";

var messages = CreateNewStreamMessages(1, 2);
var tasks = new List<Task<AppendResult>>();
for(var index = 0; index < 10; index++)
for (var index = 0; index < 10; index++)
{
tasks.Add(Store.AppendToStream(streamId, ExpectedVersion.NoStream, messages));
}

var results = await Task.WhenAll(tasks);

Assert.All(results, result => result.CurrentVersion.ShouldBe(1));
Assert.All(results, result => result.CurrentPosition.ShouldBe(results[0].CurrentPosition));
}

[Fact, Trait("Category", "AppendStream")]
public async Task When_append_to_different_streams_concurrently_with_no_stream_expected_and_same_messages_then_should_then_should_have_expected_result()
public async Task When_append_to_different_streams_concurrently_with_no_stream_expected_and_same_messages_then_should_have_expected_result()
{
// Idempotency
const string streamPrefix = "stream-";

var messages = CreateNewStreamMessages(1, 2);
var tasks = new List<Task<AppendResult>>();
for(var index = 0; index < 10; index++)
for (var index = 0; index < 10; index++)
{
tasks.Add(Store.AppendToStream(streamPrefix + index, ExpectedVersion.NoStream, messages));
}

var results = await Task.WhenAll(tasks);

Assert.All(results, result => result.CurrentVersion.ShouldBe(1));
}

[Fact, Trait("Category", "AppendStream")]
public async Task When_append_to_same_stream_concurrently_with_expected_version_any_and_different_messages_then_should_not_throw()
{
const string streamName = "stream";

var messages = CreateNewStreamMessages(1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
var tasks = new List<Task<AppendResult>>();
foreach (var message in messages)
{
tasks.Add(Store.AppendToStream(streamName, ExpectedVersion.Any, new []{message}));
}

var results = await Task.WhenAll(tasks);
results.Select(r => r.CurrentVersion).Max().ShouldBe(9);
}
}
}