Skip to content

Show when benchmarks run #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Jan 18, 2026
Merged

Show when benchmarks run #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1934b5c
Add criterion-metadata.json manually
moreal Jan 17, 2026
285df5a
Render criterion metadata
moreal Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions _data/criterion-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"generated_at": "2026-01-07T14:06:57Z",
"rustpython_commit": "c490a357fd54d578ae92681b8b1b4bae5006d843",
"rustpython_ref": "main"
}
8 changes: 8 additions & 0 deletions _layouts/benchmarks.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@
{{ content }}
</div>

{% assign metadata = site.data["criterion-metadata"] %}
<div class="text-muted mt-2">
<small>
Generated: {{ metadata.generated_at | date: "%Y-%m-%d %H:%M" }} UTC
| RustPython commit: <a href="https://github.com/RustPython/RustPython/commit/{{ metadata.rustpython_commit }}">{{ metadata.rustpython_commit | truncate: 7, "" }}</a>
</small>
</div>
Comment on lines +25 to +31
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This block can be improved for better maintainability and robustness:

  1. Hardcoded URL: The GitHub commit URL is hardcoded. It's better to use the site.github variable from _config.yml to make it more maintainable.
  2. Missing Data Check: The code doesn't check if metadata exists before trying to access its properties. If _data/criterion-metadata.json is missing, this will lead to malformed output. It's more robust to wrap the rendering logic in an {% if metadata %} block.

The suggested code below applies both improvements.

    {% assign metadata = site.data["criterion-metadata"] %}
    {% if metadata %}
        <div class="text-muted mt-2">
            <small>
                Generated: {{ metadata.generated_at | date: "%Y-%m-%d %H:%M" }} UTC
                | RustPython commit: <a href="{{ site.github }}commit/{{ metadata.rustpython_commit }}">{{ metadata.rustpython_commit | truncate: 7, "" }}</a>
            </small>
        </div>
    {% endif %}


{% assign folders = "" | split: ", " %}
{% for folder in site.static_files %}
{% if folder.path contains 'criterion/' %}
Expand Down