Skip to content

Update CI ruff to 0.15.4#7250

Open
ShaharNaveh wants to merge 3 commits intoRustPython:mainfrom
ShaharNaveh:ruff-ci-0-15-4
Open

Update CI ruff to 0.15.4#7250
ShaharNaveh wants to merge 3 commits intoRustPython:mainfrom
ShaharNaveh:ruff-ci-0-15-4

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Feb 27, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores

    • Updated CI tooling to a newer stable version.

  • Tests

    • Added a unit test verifying raw-like file IO behavior: isatty() returns False for an open instance and raises on a closed file.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b693533 and 0375ffd.

📒 Files selected for processing (2)
  • extra_tests/snippets/builtin_filter.py
  • extra_tests/snippets/stdlib_io.py
✅ Files skipped from review due to trivial changes (1)
  • extra_tests/snippets/builtin_filter.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • extra_tests/snippets/stdlib_io.py
📝 Walkthrough

Walkthrough

Bumps ruff-action from 0.14.11 to 0.15.4 in two GitHub workflows, adds a MinimalRaw test for RawIOBase.isatty() on closed files, and normalizes minor formatting in a builtin filter test snippet.

Changes

Cohort / File(s) Summary
CI workflows
/.github/workflows/ci.yaml, /.github/workflows/pr-auto-commit.yaml		 Updated ruff-action version from 0.14.11 to 0.15.4. No other workflow behavior changes.
New test snippet
extra_tests/snippets/stdlib_io.py		 Added MinimalRaw(RawIOBase) and test asserting isatty() is False when open and raises ValueError after close.
Test formatting tweak
extra_tests/snippets/builtin_filter.py		 Minor formatting normalization: removed redundant parentheses in lambda conditions; no behavior change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐰 I nibble bytes and hop through test and CI,
Bumped ruff, wrote MinimalRaw, then gave a sigh.
isatty checked, closed file found—no fright,
A little rabbit cheers the green build light. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: bumping ruff-action from 0.14.11 to 0.15.4 in CI workflows. However, the changeset includes unrelated modifications to test files (stdlib_io.py and builtin_filter.py) that are not referenced in the title.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Code has been automatically formatted

The code in this PR has been formatted using:

  • ruff format
    Please pull the latest changes before pushing again:
git pull origin ruff-ci-0-15-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ShaharNaveh