improve deps CI formatting and name resolution #6847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds module-name resolution and redirection for dependency analysis: maps hard-dep names to parent modules, recognizes Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Workflow
participant FS as Repository (Lib/, scripts/)
participant Deps as deps.py
participant Show as show_deps.py
participant API as Comments API
GH->>FS: Trigger lib-deps-check job
FS->>Deps: Collect imports (including Lib/test/*)
Deps->>Deps: parse_test_imports (handle "import test.x")
Deps->>Deps: resolve_hard_dep_parent(name)
Deps-->>Show: Emit resolved module list
Show->>Show: _resolve_module_name -> dedupe & format
Show->>API: Post/update dependency comment (recreate: true)
API-->>GH: Comment updated
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Code has been automatically formatted The code in this PR has been formatted using:
git pull origin deps-ci |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@scripts/update_lib/show_deps.py`:
- Around line 161-171: The import list in scripts/update_lib/show_deps.py
includes unused symbols—remove pathlib, parse_lib_imports, and safe_read_text
from the top-level imports since they are not used in format_deps (pathlib is
imported where needed in _resolve_module_name); update the import block that
currently brings in DEPENDENCIES, find_dependent_tests_tree, get_lib_paths,
get_test_paths, parse_lib_imports, resolve_hard_dep_parent to drop
parse_lib_imports and remove the separate safe_read_text and pathlib imports so
only actually used symbols remain.
This was referenced Jan 23, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Improvements
Style
✏️ Tip: You can customize this high-level summary in your review settings.