Skip to content

fix clippy 1.93.0 #6836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 2 commits into from
Jan 22, 2026
Merged

fix clippy 1.93.0 #6836

youknowone merged 2 commits into from
Jan 22, 2026

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Jan 22, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Improved internal pointer handling and type conversions across signal management, memory operations, and method dispatch code paths to enhance type safety and correctness.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updates function pointer casting patterns across multiple modules to use explicit intermediate pointer casts (*const ()) before final type conversion. Changes affect signal handler registration, hash sentinel detection, memory function address computation, and method descriptor comparison.

Changes

Cohort / File(s) Summary
Signal Handler Casting
crates/stdlib/src/faulthandler.rs, crates/vm/src/stdlib/signal.rs		 Function pointers cast to libc::sighandler_t now use intermediate *const () cast instead of direct type conversion for faulthandler fatal/user signal handlers and signal module handler installation
Pointer Address Computation
crates/vm/src/stdlib/ctypes.rs		 Function addresses for _memmove_addr and _memset_addr computed via *const () intermediate cast before usize conversion instead of direct cast
Type-Unsafe Pointer Comparisons
crates/vm/src/class.rs, crates/vm/src/vm/method.rs		 Hash sentinel detection and method descriptor comparison now use intermediate *const () pointer cast for safe type-level comparisons

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Faulthandler #6406: Modifies signal-handling code in faulthandler.rs; this PR adjusts function-pointer cast patterns for the same handler-wiring code paths.
  • Faulthandler #6400: Overlaps with faulthandler.rs changes; both PRs modify signal-handler installation and casting logic.
  • __hash__ to slot_wrapper #6480: Related through class.rs __hash__ slot handling; this PR refines the pointer cast used for hash_not_implemented sentinel detection.

Suggested reviewers

  • ShaharNaveh
  • arihant2math

Poem

🐰 Through pointers cast with careful care,
Each function finds its destined lair,
No direct leaps, just steps between,
The safest path our code has seen! ✨

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Code has been automatically formatted

The code in this PR has been formatted using:

  • cargo fmt --all
    Please pull the latest changes before pushing again:
git pull origin clippy

@youknowone youknowone marked this pull request as ready for review January 22, 2026 17:17
@youknowone youknowone merged commit 125ade5 into RustPython:main Jan 22, 2026
12 of 13 checks passed
@youknowone youknowone deleted the clippy branch January 22, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone