scripts/update_lib/patches.py (1)

24-30: Use explicit UTF‑8 encoding when writing output.
Locale defaults can vary; explicit UTF‑8 keeps patch output deterministic across environments.

♻️ Proposed tweak

-    with open(dest, "w") as fd:
+    with open(dest, "w", encoding="utf-8") as fd:

scripts/update_lib/path.py (1)

88-99: Consider adding type hint for consistency.

The function works correctly for the documented use cases. Consider adding a type hint for the parameter to match the style of other functions in this module:

Suggested improvement

-def test_name_from_path(test_path: pathlib.Path) -> str:
+def test_name_from_path(test_path: pathlib.Path | str) -> str:

scripts/update_lib/quick.py (4)

43-64: Consider specifying encoding for file reads.

Lines 59 and 63 use read_text() without explicit encoding. While Python 3 defaults to UTF-8 on most systems, explicitly specifying encoding="utf-8" improves cross-platform consistency and makes the intent clear.

Suggested improvement

     if lib_path.is_file():
-        return extract_test_methods(lib_path.read_text())
+        return extract_test_methods(lib_path.read_text(encoding="utf-8"))
     else:
         result = {}
         for lib_file in get_test_files(lib_path):
-            result[lib_file.resolve()] = extract_test_methods(lib_file.read_text())
+            result[lib_file.resolve()] = extract_test_methods(lib_file.read_text(encoding="utf-8"))
         return result

---

166-225: Consider using a placeholder email address.

The author string "CPython Developers <>" uses an empty email which may cause issues with certain git configurations or CI systems that validate commit metadata. Consider using a no-reply or placeholder email.

Suggested improvement

     subprocess.run(
         [
             "git",
             "commit",
             "--author",
-            "CPython Developers <>",
+            "CPython Developers <[email protected]>",
             "-m",
             message,
         ],
         check=True,
     )

---

228-260: Minor: Windows path separator not handled in shortcut check.

Line 237 only checks for "/" but not "\\", which could cause issues on Windows where paths might use backslashes. Consider normalizing first:

Suggested improvement

 def _expand_shortcut(path: pathlib.Path) -> pathlib.Path:
     # Only expand if it's a simple name (no path separators) and doesn't exist
-    if "/" in str(path) or path.exists():
+    path_str = str(path).replace("\\", "/")
+    if "/" in path_str or path.exists():
         return path

---

263-365: Consider handling subprocess.CalledProcessError for git operations.

The main() function catches ValueError and FileNotFoundError but not subprocess.CalledProcessError. If git commands fail (e.g., get_cpython_version or git_commit), the error will result in an uncaught exception with a full traceback instead of a clean error message.

Suggested improvement

+    except subprocess.CalledProcessError as e:
+        print(f"Git command failed: {e}", file=sys.stderr)
+        return 1
     except ValueError as e:
         print(f"Error: {e}", file=sys.stderr)
         return 1

Also add at the top of the file:

 import argparse
 import pathlib
+import subprocess
 import sys