Skip to content

Move compiler/source -> crates/compiler-source #6261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 8 commits into from
Nov 16, 2025
Merged

Move compiler/source -> crates/compiler-source #6261

youknowone merged 8 commits into from
Nov 16, 2025

Conversation

@ShaharNaveh
Copy link
Collaborator

@ShaharNaveh ShaharNaveh commented Nov 14, 2025 •
edited by coderabbitai bot
Loading

ref: #6214

Summary by CodeRabbit

  • Chores
    • Updated internal CI/build configuration to exclude specific packages from automated checks.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025 •
edited
Loading

Walkthrough

CI workflow configuration updated to exclude two additional crates (rustpython_wasm and rustpython-compiler-source) from clippy checks and rust test execution during continuous integration runs.

Changes

Cohort / File(s) Summary
CI workflow configuration
.github/workflows/ci.yaml		 Added rustpython_wasm and rustpython-compiler-source to clippy exclusion list and rust test command exclusions

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward configuration additions with repetitive pattern (same crates added to multiple exclusion lists)

Suggested reviewers

  • youknowone

Poem

🐰 A rabbit hops through CI workflows today,
Two crates now skip the checker's way,
Wasm and compiler sources rest,
While clippy continues its quest! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title describes moving compiler/source to crates/compiler-source, but the changes only update CI workflow exclusions for rustpython_wasm and rustpython-compiler-source without reflecting the actual directory move mentioned in the title. Clarify whether the title accurately represents all changes made, or confirm if directory restructuring commits are pending or in different branches.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42624a5 and 9c0ccfb.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Check Rust code with clippy
  • GitHub Check: Run tests under miri
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: auto_format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh mentioned this pull request Nov 14, 2025
Open
16 tasks
@fanninpm
Copy link
Contributor

fanninpm commented Nov 14, 2025

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

youknowone
youknowone reviewed Nov 15, 2025
View reviewed changes
Cargo.toml Outdated
"crates/*",
]
exclude = [
"crates/compiler-source", # deprecated. to be removed.
Copy link
Member

@youknowone youknowone Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to publish this crate as deprecated one before remove

@youknowone youknowone merged commit 93e4e42 into RustPython:main Nov 16, 2025
13 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 17, 2025
Merged
@fanninpm fanninpm mentioned this pull request Jan 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @fanninpm @youknowone