Skip to content

Conversation

@jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Sep 9, 2022

@jopemachine jopemachine changed the title Update functools lib, tests and Add singledispatch Update functools lib, tests and Add functools.singledispatch Sep 9, 2022
@youknowone
Copy link
Member

When you update python files from CPython, could you leave version message to commit log? It is helpful when we update the files to future version later. Otherwise we need to check file content to check its version.

Here is guideline: https://rustpython.github.io/blog/2020/04/04/how-to-contribute-by-cpython-unittest.html
Here is an example: #4025

@jopemachine jopemachine marked this pull request as draft September 11, 2022 09:38
@jopemachine jopemachine changed the title Update functools lib, tests and Add functools.singledispatch Update functools, threading lib and tests from CPython 3.12.0a0 Sep 12, 2022
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Sep 16, 2022
@jopemachine
Copy link
Contributor Author

I'm waiting for this issue resolved before going further. #4157

@youknowone
Copy link
Member

we'd better to step on 3.11 before 3.12. 3.12 is very early version of next cpython.

@youknowone
Copy link
Member

functools is updated by #5078. threading is not.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 4, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • Lib/test/test_threading.py is excluded by !Lib/**
  • Lib/threading.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone marked this pull request as ready for review January 4, 2026 16:16
@youknowone youknowone changed the title Update functools, threading lib and tests from CPython 3.12.0a0 Update threading lib and tests from CPython 3.12.0a0 Jan 4, 2026
@youknowone youknowone merged commit ce5e1bd into RustPython:main Jan 4, 2026
13 checks passed
terryluan12 pushed a commit to terryluan12/RustPython that referenced this pull request Jan 5, 2026
* Update threading.py from CPython v3.12.0a0

* Update test_threading.py from CPython v3.12.0a0

* mark failing tests

---------

Co-authored-by: Jeong YunWon <[email protected]>
terryluan12 pushed a commit to terryluan12/RustPython that referenced this pull request Jan 5, 2026
* Update threading.py from CPython v3.12.0a0

* Update test_threading.py from CPython v3.12.0a0

* mark failing tests

---------

Co-authored-by: Jeong YunWon <[email protected]>
terryluan12 pushed a commit to terryluan12/RustPython that referenced this pull request Jan 15, 2026
* Update threading.py from CPython v3.12.0a0

* Update test_threading.py from CPython v3.12.0a0

* mark failing tests

---------

Co-authored-by: Jeong YunWon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

z-ca-2022 Tag to track contrubution-academy 2022

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants