Skip to content

Fixes infinite recursion on raise e from e - #2820

Merged
youknowone merged 2 commits into
RustPython:masterfrom
sobolevn:issue-2779
Aug 9, 2021
Merged

Fixes infinite recursion on raise e from e#2820
youknowone merged 2 commits into
RustPython:masterfrom
sobolevn:issue-2779

Conversation

@sobolevn

@sobolevn sobolevn commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

Closes #2779

Comment thread vm/src/exceptions.rs Outdated
Comment thread vm/src/exceptions.rs Outdated
Comment thread extra_tests/snippets/builtin_exceptions.py
@DimitrisJim

Copy link
Copy Markdown
Member

Looks good to me, can you rebase the commits to get a cleaner history?

@sobolevn

sobolevn commented Aug 9, 2021

Copy link
Copy Markdown
Contributor Author

Sure!

But, you can press "Squash and merge" to merge a single commit into master: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-pull-request-commits This way it won't even re-trigget the CI 👍

Comment thread vm/src/exceptions.rs Outdated
@youknowone
youknowone merged commit 49ff438 into RustPython:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raising a user-defined class from itself causes interpreter crashing

3 participants