Skip to content

[FIX] Add needed dependency for snaps#8389

Merged
rodrigok merged 3 commits into
developfrom
fix-snap-npm-dep
Oct 5, 2017
Merged

[FIX] Add needed dependency for snaps#8389
rodrigok merged 3 commits into
developfrom
fix-snap-npm-dep

Conversation

@geekgonecrazy
Copy link
Copy Markdown
Contributor

@RocketChat/core

Closes #8365

@rodrigok @engelgabriel needed for 0.59.0 release.

@geekgonecrazy geekgonecrazy added this to the 0.59.0-rc.11 milestone Oct 3, 2017
@geekgonecrazy geekgonecrazy requested a review from rodrigok October 3, 2017 18:50
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8389 October 3, 2017 18:50 Inactive
@sampaiodiego
Copy link
Copy Markdown
Member

may I recommend update nodejs to version 4.8.4? it was a security update

@geekgonecrazy
Copy link
Copy Markdown
Contributor Author

Will do that. Also just discovered I need to do more 🤔

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8389 October 4, 2017 00:28 Inactive
@rodrigok rodrigok modified the milestones: 0.59.0-rc.11, 0.59.0-rc.12 Oct 4, 2017
@sampaiodiego
Copy link
Copy Markdown
Member

since all files are now using #{RC_VERSION} (which I don't know from where it comes from) does it still makes sense to have three files?

@rodrigok rodrigok merged commit 3a7ad8b into develop Oct 5, 2017
@rodrigok rodrigok deleted the fix-snap-npm-dep branch October 5, 2017 20:29
rodrigok added a commit that referenced this pull request Oct 6, 2017
[FIX] Add needed dependency for snaps
rodrigok added a commit that referenced this pull request Oct 6, 2017
[FIX] Add needed dependency for snaps
# Conflicts:
#	.snapcraft/candidate/snapcraft.yaml
#	.snapcraft/edge/snapcraft.yaml
#	.snapcraft/snapcraft.yaml
rodrigok added a commit that referenced this pull request Oct 9, 2017
[FIX] Add needed dependency for snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find module "fibers/future" for the 0.59.0-rc.10 version

4 participants