Remove field lastActivity from subscription data#8345
Merged
Conversation
sampaiodiego
requested changes
Sep 28, 2017
| let types = [this.identifier]; | ||
| if (this.identifier === 'activity') { | ||
| types = ['c', 'p', 'd']; | ||
| sort = { lastActivity : -1, _updatedAt: -1}; |
Member
There was a problem hiding this comment.
according to this it should still sort by _updatedAt
Member
Author
There was a problem hiding this comment.
@sampaiodiego @engelgabriel sort is not used if the indentifier === "activity"
engelgabriel
requested changes
Sep 28, 2017
Member
engelgabriel
left a comment
engelgabriel
left a comment
There was a problem hiding this comment.
We need a migration to remove lastActivity from the DB
Member
Author
|
@engelgabriel could you review migration 101? |
engelgabriel
approved these changes
Sep 29, 2017
sampaiodiego
approved these changes
Sep 29, 2017
rodrigok
changed the title
lastActivity from subscription data
rodrigok
added a commit
that referenced
this pull request
Oct 3, 2017
Remove field `lastActivity` from subscription data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8338