[FIX] Remove sidebar header on admin embedded version#8334
Merged
Conversation
| } | ||
| }, | ||
| embeddedVersion() { | ||
| console.log('burger', RocketChat.Layout.isEmbedded()); |
engelgabriel
previously requested changes
Sep 27, 2017
| <div class="rooms-list"> | ||
| {{#unless embeddedVersion}} | ||
| <header class="sidebar__header"> | ||
| {{> accountBox lighten=true modifier="--account" }} |
Contributor
Author
There was a problem hiding this comment.
I can remove that, but I won't do that on this PR. This PR is about embedded view and not about accountBox.
| <div class="rooms-list" aria-label="{{_ "Administration"}}"> | ||
| {{#unless embeddedVersion}} | ||
| <header class="sidebar__header"> | ||
| {{> accountBox lighten=true modifier="--admin"}} |
Member
There was a problem hiding this comment.
Also remove this account box
Contributor
Author
There was a problem hiding this comment.
I can remove that, but I won't do that on this PR. This PR is about embedded view and not about accountBox.
| {{> accountBox lighten=true modifier="--admin"}} | ||
| <button class="sidebar-flex__back-button" data-action="back"> | ||
| {{> icon block="sidebar-flex__back-icon" icon="back"}} | ||
| <span>{{_ "Back_to_chat"}}</span> |
Member
There was a problem hiding this comment.
Change "Back_to_chat" to just "Back"
Contributor
Author
There was a problem hiding this comment.
ok, it's easy to maintain translations :)
| {{> accountBox lighten=true modifier="--account" }} | ||
| <button class="sidebar-flex__back-button" data-action="back"> | ||
| {{> icon block="sidebar-flex__back-icon" icon="back"}} | ||
| <span>{{_ "Back_to_chat"}}</span> |
Member
There was a problem hiding this comment.
Change "Back_to_chat" to just "Back"
rodrigok
approved these changes
Sep 29, 2017
rodrigok
added a commit
that referenced
this pull request
Sep 29, 2017
[FIX] Remove sidebar header on admin embedded version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8333