Conversation
applied sidenav and room
Contributor
|
@ggazzo Could you use NPM module instead Meteor packages? |
Member
Author
|
yes I can , but I won't <3 |
Member
Author
|
@MartinSchoeler could you see the error plz? :) |
Member
Author
|
thanks @rodrigok |
rodrigok
approved these changes
Sep 20, 2017
rodrigok
added a commit
that referenced
this pull request
Sep 20, 2017
[FIX] Scrollbar not using new style
Contributor
|
@ggazzo , @karlprieb , @rodrigok Please visit above issue. ( #8223 ) |
Member
|
@cyclops24 It was my fault, the PR was in progress and with test erros, so I fixed the tests and thought was the reason to be in progress, so I merged it. I created a new PR (#8244) disabling the scrollbar implementation and @ggazzo will finish the implementation in another PR. Thanks by your review 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applied on sidenav and room
@RocketChat/core
Closes #8049