Skip to content

[NEW] Replace message cog for vertical menu#7864

Merged
rodrigok merged 7 commits into
developfrom
vertical-menu
Aug 25, 2017
Merged

[NEW] Replace message cog for vertical menu#7864
rodrigok merged 7 commits into
developfrom
vertical-menu

Conversation

@karlprieb
Copy link
Copy Markdown
Contributor

@RocketChat/core

image

image

image

image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7864 August 24, 2017 21:28 Inactive
@graywolf336
Copy link
Copy Markdown
Contributor

@karlprieb looking good! I see a few things changed with how message actions are defined. Can you give an overview or description? As I see group but I am left with a few questions. What are valid values for it? What's it for?

I ask because these changes directly affect Rocketlets and we was just getting started on the message action buttons.

@engelgabriel engelgabriel added this to the 0.59.0 milestone Aug 24, 2017
@karlprieb
Copy link
Copy Markdown
Contributor Author

@graywolf336 Thanks! The changes on messageActions are simple, I changed i18nLabel to label and validation to condition to maintain the standard of nomenclature used on other packages and added group.
As you can see on the comment group can be menu or message.

If group is set to menu it will be added to this vertical menu, if group is message it will appear on the message (next to menu icon that opens the vertical menu).

@graywolf336
Copy link
Copy Markdown
Contributor

@karlprieb Perfect, thanks for the answers! 👍

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7864 August 24, 2017 23:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants