Escape error messages#7308
Merged
Merged
Conversation
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
should the return of TAPi18n.__ be escaped instead of translation key?
Member
Author
|
@sampaiodiego Why, the result is the combination of the user input with the translation string, the only part that can be used to execute JS without our knowledge is the user input. That way we allow some HTML formatting inside our translation strings prevent undesired HTML execution from user input. |
sampaiodiego
approved these changes
Jun 27, 2017
rodrigok
added a commit
that referenced
this pull request
Jun 28, 2017
…ssages Escape error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core