Conversation
closes 6922 closes 6917
| # If greater then 10MB don't try and show a preview | ||
| if file.file.size > 10 * 1000000 | ||
| callback(file, null) | ||
| else if file.file.type is undefined |
Member
There was a problem hiding this comment.
maybe testing any falsy value would be safier.. what do you think? like else if not file.file.type?
Contributor
Author
There was a problem hiding this comment.
Of course 👍 makes sense. That's coffeescript for you lol
Contributor
Author
|
@sampaiodiego fixed 👍 |
sampaiodiego
approved these changes
May 11, 2017
rodrigok
added a commit
that referenced
this pull request
May 11, 2017
[Fix] Error when trying to show preview of undefined filetype
|
i'm on 0.57.3. i'm able to upload an extension-less file, but trying to download it will fail in browser & do nothing in app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6922
closes #6917
@RocketChat/core
Closes #ISSUE_NUMBER