[NEW] Feature/delete any message permission#6919
Merged
rodrigok merged 7 commits intoMay 10, 2017
Merged
Conversation
|
|
marceloschmidt
approved these changes
May 9, 2017
Member
marceloschmidt
left a comment
marceloschmidt
left a comment
There was a problem hiding this comment.
I'd probably rename delete-any-message to force-delete-message but all the rest is looking good.
Contributor
Author
|
Thanks @marceloschmidt! |
Contributor
Author
|
@marceloschmidt our of curiousity, whats the merge release frequency/schedule look like for this? |
Member
|
Ah, that's a tough question :( let me see if I can speed it up. |
rodrigok
approved these changes
May 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
This addresses: #4921
Summary
This adds an option called delete-any-message (maybe we should rename), which by default allows admins and owners to delete any message overriding the time window for deletion.
Solves...
The problem that this solves is when you have
Block Message Deleting After (n) Minutesturned on, once that timeframe has expired, even admins and owners cannot delete messages without temporarily turning this setting off.Considerations
Setting Name
Currently the setting is named
delete-any-messagebut I've considered something likemessage-delete-block-overrideand am open to suggestions...Permission Retrieval
I'm using hasAtLeastOnePermisison, with one permisison, to find the permission and do the conditionals. I would have liked to use
hasPermissionwith an array containingdelete-any-messageanddelete-messagebut with the way that theblockDeleteInMinutesis structured, it proved difficult so I've left it this way. It works fine this way but I'm open to suggestions on how to handle this if there are better ideas.Tests
Tests are passing...
I've not written any tests to cover this yet. There may be tests that cover this mostly but wanted input before writing any tests. Suggestions welcome.