Convert WebRTC Package to Js#6775
Merged
Merged
Conversation
still need to add the coments
ggazzo
reviewed
May 11, 2017
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
you are better than a coffee compiler, then fix the things they cant do right :) .
| this.TransportClass = WebRTCTransportClass; | ||
| this.selfId = selfId; | ||
| this.room = room; | ||
| this.config.iceServers = []; |
Member
There was a problem hiding this comment.
remove this line :) because its already defined at 160
| url: URL.createObjectURL(remoteStream), | ||
| state: peerConnection.iceConnectionState | ||
| }; | ||
| console.log(item); |
| } | ||
|
|
||
| setVideoEnabled(enabled) { | ||
| if (enabled == null) { |
| } | ||
|
|
||
| setScreenShareEnabled(enabled) { | ||
| if (enabled == null) { |
| this.active = false; | ||
| this.monitor = false; | ||
| this.remoteMonitoring = false; | ||
| if ((this.localStream != null) && typeof this.localStream !== 'undefined') { |
| */ | ||
|
|
||
| startCall(media) { | ||
| if (media == null) { |
| if (this.autoAccept === true) { | ||
| FlowRouter.goToRoomById(data.room); | ||
| Meteor.defer(() => { | ||
| return this.joinCall({ |
| desktop {Boolean} | ||
| */ | ||
|
|
||
| joinCall(data) { |
| ChromeScreenShare.screenCallback = callback; | ||
| if (navigator === 'electron') { | ||
| return fireGlobalEvent('get-sourceId', '*'); | ||
| } else { |
Member
There was a problem hiding this comment.
you dont need an else statement if you have a return into the if
| if (ChromeScreenShare.screenCallback != null) { | ||
| return ChromeScreenShare.screenCallback('PermissionDeniedError'); | ||
| } else { | ||
| throw new Error('PermissionDeniedError'); |
Member
There was a problem hiding this comment.
you dont need an else statement if you have a return into the if
ggazzo
previously requested changes
May 11, 2017
| this.updateRemoteItems(); | ||
| }); | ||
| peerConnection.addEventListener('iceconnectionstatechange', () => { | ||
| let ref; |
rodrigok
approved these changes
May 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core