[FIX] Accounts from LinkedIn OAuth without name#6590
Merged
Conversation
rodrigok
requested review from
engelgabriel,
graywolf336,
marceloschmidt and
sampaiodiego
sampaiodiego
reviewed
Apr 4, 2017
|
|
||
| RocketChat.models.Users.find(query, {'services.linkedin.firstName': 1, username: 1}).forEach((user) => { | ||
| const name = `${ user.services.linkedin.firstName } ${ user.services.linkedin.lastName }`; | ||
| console.log(name); |
Member
There was a problem hiding this comment.
I think this console.log can be removed =)
sampaiodiego
reviewed
Apr 4, 2017
| if (options.profile) { | ||
| if (options.profile.name) { | ||
| user.name = options.profile.name; | ||
| } else if (options.profile.firstName && options.profile.lastName) { |
Member
There was a problem hiding this comment.
can it happen to have the firstName but not the lastName?
If so, it would be better to split the if in two so the user will got at least the firstName
Member
Author
There was a problem hiding this comment.
Non of our 500+ cases had only firstName, but I'll change
sampaiodiego
approved these changes
Apr 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
I removed the migration for Real Names cuz it takes hours to run on our demo, we are working to fix that.