rocketchat-channel-settings-mail-messages coffee to js#6541
Merged
engelgabriel merged 2 commits intoApr 3, 2017
Merged
Conversation
ggazzo
changed the title
ggazzo
force-pushed
the
rocketchat-channel-settings-mail-messages
branch
2 times, most recently
from
00c0d64 to
b284dfe
Compare
rodrigok
requested changes
Mar 31, 2017
Member
rodrigok
left a comment
rodrigok
left a comment
There was a problem hiding this comment.
I'll continue the review after changes
Member
There was a problem hiding this comment.
Why pass always true? Some places passes false
Member
There was a problem hiding this comment.
What do you think? const [el] = $('.messages-box');
ggazzo
force-pushed
the
rocketchat-channel-settings-mail-messages
branch
2 times, most recently
from
e18746b to
d90b48d
Compare
ggazzo
force-pushed
the
rocketchat-channel-settings-mail-messages
branch
from
d90b48d to
d66c833
Compare
rodrigok
requested changes
Mar 31, 2017
| }, | ||
| email() { | ||
| const {emails} = Meteor.user(); | ||
| return emails && emails[0].address; |
Member
There was a problem hiding this comment.
emails can exists but be empty
| const emails = t.$('input[name=to_emails]').val().trim().split(','); | ||
| const erroredEmails = []; | ||
| for (let j = 0, len = emails.length; j < len; j++) { | ||
| const email = emails[j]; |
| if (data.to_users.length > 0) { | ||
| _.each(data.to_users, (username) => { | ||
| const user = RocketChat.models.Users.findOneByUsername(username); | ||
| if (user && user.emails && user.emails[0].address) { |
rodrigok
approved these changes
Apr 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.