Skip to content

converted getAvatarUrlFromUsername#6496

Merged
engelgabriel merged 3 commits into
RocketChat:developfrom
ggazzo:getAvatarUrlFromUsername
Mar 29, 2017
Merged

converted getAvatarUrlFromUsername#6496
engelgabriel merged 3 commits into
RocketChat:developfrom
ggazzo:getAvatarUrlFromUsername

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Mar 27, 2017

@RocketChat/core

@ggazzo ggazzo force-pushed the getAvatarUrlFromUsername branch from 464a547 to 424e9a0 Compare March 27, 2017 20:06
@ggazzo ggazzo force-pushed the getAvatarUrlFromUsername branch from 424e9a0 to 5b9c0fe Compare March 27, 2017 20:35
} else if (Meteor.isCordova) {
path = Meteor.absoluteUrl().replace(/\/$/, '');
}
return `${ path }/avatar/${ (encodeURIComponent(username)) }?_dc=${ random }`;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these extra parenthesis?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inherit from old code, removed.

@engelgabriel engelgabriel modified the milestone: 0.55.0 Mar 29, 2017
@engelgabriel engelgabriel merged commit d1ca15b into RocketChat:develop Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants