Merge pull request #815 from kukulich/php81-function-is-static

Ocramius · web-flow · commit e2fa610110f8 · 2021-10-14T17:50:34.000+02:00
PHP 8.1: Implemented `ReflectionFunction::isStatic()`
diff --git a/src/Reflection/Adapter/ReflectionFunction.php b/src/Reflection/Adapter/ReflectionFunction.php
@@ -231,6 +231,6 @@ public function getClosureUsedVariables(): array
 
     public function isStatic(): bool
     {
-        throw new Exception\NotImplemented('Not implemented');
+        return $this->betterReflectionFunction->isStatic();
     }
 }
diff --git a/src/Reflection/ReflectionFunction.php b/src/Reflection/ReflectionFunction.php
@@ -77,6 +77,13 @@ public function isDisabled(): bool
         return false;
     }
 
+    public function isStatic(): bool
+    {
+        $node = $this->getAst();
+
+        return ($node instanceof Node\Expr\Closure || $node instanceof Node\Expr\ArrowFunction) && $node->static;
+    }
+
     /**
      * @throws NotImplemented
      * @throws FunctionDoesNotExist
diff --git a/test/unit/Reflection/Adapter/ReflectionFunctionTest.php b/test/unit/Reflection/Adapter/ReflectionFunctionTest.php
@@ -91,7 +91,7 @@ public function methodExpectationProvider(): array
             ['invoke', null, null, []],
             ['invokeArgs', null, null, [[]]],
             ['getClosure', null, $closure, []],
-            ['isStatic', NotImplemented::class, null, []],
+            ['isStatic', null, true, []],
         ];
     }
 
diff --git a/test/unit/Reflection/ReflectionFunctionTest.php b/test/unit/Reflection/ReflectionFunctionTest.php
@@ -185,6 +185,47 @@ public function testCreateFromClosureWithArrowFunctionCanReflectTypesInNamespace
         self::assertSame(ClassWithStaticMethod::class, $theParam->getName());
     }
 
+    public function testIsStaticFromClosure(): void
+    {
+        // phpcs:disable SlevomatCodingStandard.Functions.RequireArrowFunction
+        $closure = static function () {
+            return 5;
+        };
+        // phpcs:enable
+        $reflection = ReflectionFunction::createFromClosure($closure);
+        self::assertTrue($reflection->isStatic());
+    }
+
+    public function testIsNotStaticFromClosure(): void
+    {
+        // phpcs:disable SlevomatCodingStandard.Functions.RequireArrowFunction
+        // phpcs:disable SlevomatCodingStandard.Functions.StaticClosure.ClosureNotStatic
+        $closure = function () {
+            return 5;
+        };
+        // phpcs:enable
+        $reflection = ReflectionFunction::createFromClosure($closure);
+        self::assertFalse($reflection->isStatic());
+    }
+
+    public function testIsStaticFromArrowFunction(): void
+    {
+        $closure = static fn () => 5;
+
+        $reflection = ReflectionFunction::createFromClosure($closure);
+        self::assertTrue($reflection->isStatic());
+    }
+
+    public function testIsNotStaticFromArrowFunction(): void
+    {
+        // phpcs:disable SlevomatCodingStandard.Functions.StaticClosure.ClosureNotStatic
+        $closure = fn () => 5;
+        // phpcs:enable
+
+        $reflection = ReflectionFunction::createFromClosure($closure);
+        self::assertFalse($reflection->isStatic());
+    }
+
     public function testToString(): void
     {
         require_once __DIR__ . '/../Fixture/Functions.php';

Original file line number	Diff line number	Diff line change
`@@ -231,6 +231,6 @@ public function getClosureUsedVariables(): array`
`231`	`231`
`232`	`232`	`public function isStatic(): bool`
`233`	`233`	`{`
`234`		`- throw new Exception\NotImplemented('Not implemented');`
	`234`	`+ return $this->betterReflectionFunction->isStatic();`
`235`	`235`	`}`
`236`	`236`	`}`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ public function methodExpectationProvider(): array`
`91`	`91`	`['invoke', null, null, []],`
`92`	`92`	`['invokeArgs', null, null, [[]]],`
`93`	`93`	`['getClosure', null, $closure, []],`
`94`		`- ['isStatic', NotImplemented::class, null, []],`
	`94`	`+ ['isStatic', null, true, []],`
`95`	`95`	`];`
`96`	`96`	`}`
`97`	`97`