WIP: [2c] PageLayout error handling and chart skeletons #5600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates PageLayout to handle count loading errors gracefully: - Adds CountError component showing "—" with tooltip on error - Uses Await pattern for async count loading - Shows Skeleton during loading state Adds chart skeleton components for loading states: - LineChartSkeleton in ModelLatency - ChartSkeleton in ModelUsage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: WIP - NOT READY FOR REVIEW
This is part of the error boundaries work, split into separate PRs for review.
Stacked on: #5588
Summary
Updates PageLayout to handle count loading errors gracefully:
CountErrorcomponent showing "—" with tooltip on errorAwaitpattern for async count loadingAdds chart skeleton components for loading states:
LineChartSkeletonin ModelLatencyChartSkeletonin ModelUsageTest plan