Nested joins - #145
Closed
slowcheetahzzz wants to merge 1 commit into
Closed
Conversation
slowcheetahzzz
changed the base branch from
master
to
nested_joins_compatibility
August 11, 2026 15:38
MadSchemas
requested changes
Aug 13, 2026
| db.upsert("roles", role); | ||
|
|
||
| Query<Actor> actorQuery = db.query("actors", Actor.class) | ||
| .innerJoin(db.query("roles", Role.class), "joinedRoles") |
Contributor
There was a problem hiding this comment.
Покрытие позитивных сценариев хорошо бы расширить. Как минимум:
- комбинации вложенных left/inner
- позитивный тест-кейс merge + nested joins
- позитивный тест-кейс на nested join с глубиной вложенности 2+
slowcheetahzzz
force-pushed
the
nested_joins
branch
from
August 13, 2026 15:15
3667125 to
9bb1f9f
Compare
MadSchemas
reviewed
Aug 14, 2026
| if (format != QUERY_FORMAT_V2) { | ||
| String errorMessage = String.format("QueryResults format version='%d' is not supported", format); | ||
| throw new RuntimeException(errorMessage); | ||
| buffer.rewind(); |
Contributor
There was a problem hiding this comment.
Тут был бросок исключения, и он по смыслу был праввильным
MadSchemas
reviewed
Aug 14, 2026
|
|
||
| @Override | ||
| public boolean supportsNestedJoinQueries() { | ||
| return builtin.supportsNestedJoinQueries(); |
Contributor
There was a problem hiding this comment.
Флаг выглядит избыточным. Если используется QueryFormatV2, то мы гарантированно поддерживаем nested joins
MadSchemas
reviewed
Aug 14, 2026
| reindexer_string dsn = rx_string(env, path); | ||
| reindexer_string vers = rx_string(env, version); | ||
| int64_t capabilities = kBindingCapabilityResultsWithShardIDs | kBindingCapabilityComplexRank; | ||
| if (queryFormatVersion == QueryFormatV2) { |
Contributor
There was a problem hiding this comment.
Builtin всегда работает по V2, логика лишняя
MadSchemas
reviewed
Aug 14, 2026
| return parsedVersion[2] >= NESTED_JOIN_QUERIES_MIN_PATCH; | ||
| } | ||
|
|
||
| private int[] parseVersion(String version) { |
Contributor
There was a problem hiding this comment.
Вся логика с парсингом версии избыточна - у нас уже есть caps, который определяет поддержу nested join
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.