MOD-14324 C API for getting array slice and type#1521
Merged
AvivDavid23 merged 10 commits intomasterfrom Mar 30, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1521 +/- ##
==========================================
- Coverage 78.05% 76.84% -1.21%
==========================================
Files 15 15
Lines 3942 4004 +62
==========================================
Hits 3077 3077
- Misses 865 927 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…c-api-for-json-set-hfpa
oshadmi
reviewed
Mar 25, 2026
oshadmi
reviewed
Mar 25, 2026
oshadmi
reviewed
Mar 25, 2026
oshadmi
reviewed
Mar 25, 2026
oshadmi
reviewed
Mar 25, 2026
oshadmi
reviewed
Mar 25, 2026
oshadmi
reviewed
Mar 26, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
oshadmi
reviewed
Mar 30, 2026
oshadmi
approved these changes
Mar 30, 2026
AvivDavid23
added a commit
that referenced
this pull request
Mar 30, 2026
* MOD-14324 C API for getting array slice and type * remove mistakenly added function * cargo fmt * CR * CR * typo * add comment * add namespace for enum * test vars init
AvivDavid23
added a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Extends the public C API with a new
getArrayentry that returns raw array buffer pointers and type tags, which is FFI- and memory-safety sensitive if callers misuse lifetimes or heterogeneous arrays.Overview
Adds RedisJSON C API v7 support for retrieving an array’s underlying contiguous buffer plus its element type.
This introduces a shared
JSONArrayTypeenum injson_path, extends theSelectValuetrait withget_array/get_array_type, implements them for bothserde_json::Valueandijson::IValue(including typed numeric array slices), and wires a new exportedJSONAPI_getArray/getArrayfunction throughrejson_api.h(bumpingRedisJSONAPI_LATEST_API_VERto7). Unit tests were added to validate returned pointers, lengths, and type tags across heterogeneous and typed arrays.Written by Cursor Bugbot for commit fff92bd. This will update automatically on new commits. Configure here.