OperatorReduce - prevent multiple terminal events - #4246
Merged
akarnokd merged 1 commit intoJul 28, 2016
Merged
Conversation
| actual.onError(e); | ||
| if (!done) { | ||
| done = true; | ||
| actual.onError(e); |
Collaborator
There was a problem hiding this comment.
Isn't here RxJavaHooks.onError missing?
Current coverage is 84.30% (diff: 100%)@@ 1.x #4246 diff @@
==========================================
Files 266 266
Lines 17426 17434 +8
Methods 0 0
Messages 0 0
Branches 2649 2652 +3
==========================================
+ Hits 14676 14697 +21
+ Misses 1893 1873 -20
- Partials 857 864 +7
|
davidmoten
force-pushed
the
operator-reduce-prevent-multiple-terminal-events
branch
from
July 27, 2016 21:41
0865a71 to
83f2108
Compare
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion in #4242, if an operator maps an
onNextemission to anonErroremission downstream then it needs be defensive about anonCompletedbeing sent from upstream even if upstream has been unsubscribed.Includes a unit test that failed on the original code.
Also renamed test class to match tested class.