Fix retryWhen/repeatWhen potential concurrent reentry when resubscribing - #4241
Merged
Merged
Conversation
Current coverage is 84.23% (diff: 100%)@@ 1.x #4241 diff @@
==========================================
Files 265 265
Lines 17313 17313
Methods 0 0
Messages 0 0
Branches 2627 2627
==========================================
+ Hits 14578 14583 +5
+ Misses 1885 1880 -5
Partials 850 850
|
Contributor
|
👍 |
Collaborator
|
Worth a shot, gnarly bug 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the function's returned Observable signals the resubscription in the operator
redo(which is the base forrepeatWhenandretryWhen). It is possible an asyncronous source triggers the function (and thus the sameObservable) from another thread while the first is still coming back from the resubscription itself.This PR serializes the dispatching
BehaviorSubjectto prevent such concurrent execution of the when chain.This may or may not be the source of the failure of #4175 but I can't reproduce the failure with the 1.x branch. /cc @davidmoten.