Fixes the progress bar for jupyter notebooks #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPaulSharp
approved these changes
Aug 14, 2024
Collaborator
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
All looks good to me, and works as expected. I have two suggestions:
- When the calculation is running the text left of the bar says "DREAM:" but when it finishes it changes to "end:" Is this your intention?
- If possible, I think it would be better to have a blank line between the progress bar and "time elapsed" line.
Contributor
Author
No, that was the original way the code was written, I fixed it in my last RAT PR. I just have not updated the C++
Will do |
StephenNneji
force-pushed
the
fix_progress_bar
branch
from
900aad8 to
04f411a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.