Call pip with the subprocess module. #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This will make things more robust, great! I typed up a long concern about finding the wrong pip on the system path, but then I finally noticed you're using Because of that, I'm sure this will work even for people on Linux/Mac who run |
tarehart
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pip is not supposed to be imported. The recommended method is to call pip as a subprocess, see https://pip.pypa.io/en/latest/user_guide/#using-pip-from-your-program
I have decided to use
subprocess.calloversubprocess.check_callbecause the latter throws an exception when a package fails to install. The rlbottraining package fails to install if the python version is below 3.7 but is not required to succesfully run rlbot.