Skip to content

fix issue 693, Fail compiling Quick using Carthage because of SwiftLint#694

Merged
jeffh merged 2 commits intoQuick:masterfrom
nerd0geek1:master
Mar 7, 2017
Merged

fix issue 693, Fail compiling Quick using Carthage because of SwiftLint#694
jeffh merged 2 commits intoQuick:masterfrom
nerd0geek1:master

Conversation

@nerd0geek1
Copy link
Copy Markdown
Contributor

close #693

What behavior was changed?

  • SwiftLint will be execute only in Test(It isn't executed in Build).

What I did

  • delete SwiftLint Run Script Phase from Quick-macOS/Quick-iOS/Quick-tvOS target.
  • add Aggregate to execute SwiftLint Run Script

The reason why I submit this PR is written on #693, so please refer it.

@QuickBot
Copy link
Copy Markdown

1 Warning
⚠️ Big PR

Generated by 🚫 danger

@wongzigii
Copy link
Copy Markdown
Member

Thanks for this! 👍

@jeffh jeffh merged commit 101f944 into Quick:master Mar 7, 2017
@jeffh
Copy link
Copy Markdown
Member

jeffh commented Mar 7, 2017

Thanks @nerd0geek1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail compiling Quick using Carthage because of SwiftLint

4 participants