Add GitHub Action workflow for checks #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
approved these changes
Apr 14, 2020
.github/workflows/check.yml
Outdated
| pull_request: | ||
| push: | ||
| jobs: | ||
| pre-commit: |
Contributor
There was a problem hiding this comment.
Suggested change
| pre-commit: | |
| check: |
.github/workflows/check.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-python@v1 | ||
| - run: pip install tox pre-commit |
Contributor
There was a problem hiding this comment.
Suggested change
| - run: pip install tox pre-commit | |
| - run: pip install tox |
tox already installs pre-commit.
.github/workflows/check.yml
Outdated
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-python@v1 | ||
| - run: pip install tox pre-commit | ||
| - run: pip install -r requirements.txt -r test-requirements.txt |
Contributor
There was a problem hiding this comment.
It is usually safer to edit test-requirements.txt to have the first line be -r requirements.txt but this will work as well.
This was referenced Apr 14, 2020
To integrate better with the GitHub workflow, add a workflow for checking pushes and PRs. This doesn't remove the Travis configuration, which is still required for releases. Co-Authored-By: Christian Clauss <[email protected]>
s-t-e-v-e-n-k
force-pushed
the
add-gh-workflow
branch
from
2b9b9d2 to
165bf4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To integrate better with the GitHub workflow, add a workflow for
checking pushes and PRs. This doesn't remove the Travis configuration,
which is still required for releases.
Co-Authored-By: Christian Clauss [email protected]