Skip to content

observation/FOUR-13973 In processes some columns are not resizing#6141

Merged
ryancooley merged 7 commits into
nextfrom
observation/FOUR-13973
Feb 5, 2024
Merged

observation/FOUR-13973 In processes some columns are not resizing#6141
ryancooley merged 7 commits into
nextfrom
observation/FOUR-13973

Conversation

@gustavobascope

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

In processes some columns are not resizing

Solution

fixed the column attributes and added sorting

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-13973

ci:deploy
ci:next

@tokensPM

tokensPM commented Feb 1, 2024

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

@nolanpro nolanpro self-requested a review February 1, 2024 22:39

@nolanpro nolanpro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobascope A few things I noticed

  • Can we fix this problem where dragging is causing the text to truncate even when the column is not moving?
column1.mov
  • It seems to cut off more space then necessary. The red boxes are empty space that could be used:
    image

  • Can we fix the background color? It looks like it shifted a few pixels to the right. It should fit inside the grey lines:
    image

@tokensPM

tokensPM commented Feb 2, 2024

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

@tokensPM

tokensPM commented Feb 2, 2024

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

@gustavobascope

Copy link
Copy Markdown
Contributor Author

@gustavobascope A few things I noticed

  • Can we fix this problem where dragging is causing the text to truncate even when the column is not moving?

column1.mov

  • It seems to cut off more space then necessary. The red boxes are empty space that could be used:
    image
  • Can we fix the background color? It looks like it shifted a few pixels to the right. It should fit inside the grey lines:
    image

@nolanpro I solved the observations

@tokensPM

tokensPM commented Feb 5, 2024

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

@processmaker-sonarqube

Copy link
Copy Markdown

@tokensPM

tokensPM commented Feb 5, 2024

Copy link
Copy Markdown

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

@nolanpro nolanpro self-requested a review February 5, 2024 17:23
@nolanpro

nolanpro commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

@gustavobascope looks good, thanks!

@ryancooley ryancooley merged commit f09f61a into next Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants