Fix: Server Send Always Uses Binary Frame Type for Text Messages#102
Open
prjanitor wants to merge 1 commit intoPowerShellWeb:mainfrom
Open
Fix: Server Send Always Uses Binary Frame Type for Text Messages#102prjanitor wants to merge 1 commit intoPowerShellWeb:mainfrom
prjanitor wants to merge 1 commit intoPowerShellWeb:mainfrom
Conversation
Changed the frame type from 'Binary' to 'Text' when sending text/JSON messages from the server. This ensures compliance with the WebSocket protocol specification and prevents clients from misinterpreting text data as binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
In the server-side
Send.ps1, text messages were incorrectly sent with 'Binary' frame type instead of 'Text', which violates the WebSocket protocol and causes clients to misinterpret text data as binary.Fix
Changed the frame type parameter in
socket.SendAsync()from'Binary'to'Text'for the text message branch (the else branch that handles non-binary data).Before
After
Impact
This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.