Skip to content

Rename private methods in MshCommandRuntime.cs #9074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ilya (iSazonov) merged 1 commit into from
Mar 8, 2019
Merged

Rename private methods in MshCommandRuntime.cs #9074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/System.Management.Automation/engine/MshCommandRuntime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ public void WriteObject(object sendToPipeline, bool enumerateCollection)

#if CORECLR
// SecurityContext is not supported in CoreCLR
DoWriteObjects(sendToPipeline);
DoWriteEnumeratedObject(sendToPipeline);
#else
if (UseSecurityContextRun)
{
Expand Down Expand Up @@ -278,11 +278,11 @@ public void WriteObject(object sendToPipeline, bool enumerateCollection)
/// <exception cref="System.InvalidOperationException">
/// Not permitted at this time or from this thread
/// </exception>
private void DoWriteObjects(object sendToPipeline)
private void DoWriteEnumeratedObject(object sendToPipeline)
{
// NOTICE-2004/06/08-JonN 959638
ThrowIfWriteNotPermitted(true);
_WriteObjectsSkipAllowCheck(sendToPipeline);
_EnumerateAndWriteObjectSkipAllowCheck(sendToPipeline);
}
// Trust: public void WriteObject(object sendToPipeline, DataTrustCategory trustCategory); // enumerateCollection defaults to false
// Trust: public void WriteObject(object sendToPipeline, bool enumerateCollection, DataTrustCategory trustCategory);
Expand Down Expand Up @@ -2591,7 +2591,7 @@ internal void _WriteObjectSkipAllowCheck(object sendToPipeline)
/// The Cmdlet should generally just allow PipelineStoppedException
/// to percolate up to the caller of ProcessRecord etc.
/// </exception>
internal void _WriteObjectsSkipAllowCheck(object sendToPipeline)
internal void _EnumerateAndWriteObjectSkipAllowCheck(object sendToPipeline)

@iSazonov Ilya (iSazonov) Mar 6, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
internal void _EnumerateAndWriteObjectSkipAllowCheck(object sendToPipeline)
internal void EnumerateAndWriteObjectSkipAllowCheck(object sendToPipeline)

@vexx32 Rain Sallow (/u/ta11ow) (vexx32) Mar 6, 2019

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I go that route it might be better to just rename half the things in this file, in all honesty... There are a lot of similarly questionable names here.

@iSazonov Ilya (iSazonov) Mar 6, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no. It is better to spend time to create something useful.

@vexx32 Rain Sallow (/u/ta11ow) (vexx32) Mar 6, 2019

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll come back to it when I'm really bored and do a proper style pass over the whole thing. 😉

Not a big-ticket item, but there's a lot of room for tidying up in this one. 😄

{
IEnumerable enumerable = LanguagePrimitives.GetEnumerable(sendToPipeline);
if (enumerable == null)