Clean Up Full CLR Code From Web Cmdlets - #5376

Mark Kraus (@markekraus) Could you please review all files and add a newline at EOF?

Ilya (@iSazonov) All of the files I modified in the PR have a newline EOF. Some of them did not have one before and just ended with #endif.

Mark Kraus (@markekraus) does it make sense to move the files in common and CoreCLR to the parent and get rid of those subdirs?

Steve Lee (@SteveL-MSFT) If it were up to me. I would combine the core partials and the common partials and move them all to the parent webcmdlet folder. It would definitely make these a lot easier to work on since there is no FullCLR to contend with. I'm not sure if it makes sense to do that and this cleanup in the same PR, though. But I would definitely want it that way, whether in this PR or another.

I believe it is more easily and faster to review small PRs.
The PR LGTM and I vote to merge now.

Ilya (@iSazonov) do you think I should do the merging of partials in one PR and then the file moves in another? otherwise... it will just look like I created new classes in parent folder and deleted old ones. Hard to see how they were put together. I could just do them as 2 commits in the same PR too.

Mark Kraus (@markekraus) use git mv and git will report the file was just moved

Steve Lee (@SteveL-MSFT) as an example, I want to take WebCmdlet\Common\BasicHtmlWebResponseObject.Common.cs and WebCmdlet\CoreCLR\BasicHtmlWebResponseObject.CoreClr.cs, and combine them to WebCmdlet\BasicHtmlWebResponseObject.cs

Mark Kraus (@markekraus) I see, if you're combining files, I agree you should do that as a separate PR.

Steve Lee (@SteveL-MSFT) for clarity, should I do 1 PR for combining, and another PR for the move? Or just do both in 1 PR (with 2 commits)?

Mark Kraus (@markekraus) I think you can just do 1 PR for combining/move and have them as separate commits

Mark Kraus (@markekraus) can you resolve the merge conflict? As discussed in the issue, we'll defer further clean-up work and should merge this once the merge conflict is resolved

Steve Lee (@SteveL-MSFT) conflict resolved, but I just realized I never ran Feature tests in this PR. so running now.

The one of the fails (EventResource) in AppVeyor is appearing in all builds, not just this one. I assume it's a known issue.

The other is a timeout fail from httpbin.org (I will get those tests all moved over to WebListener someday).

As for Travis CI, it seems to be having unrelated issues

Yes, we are waiting #5379 to pass CI AppVeyor.

Ilya (@iSazonov) al tests pass now