Fix tooltip for variable expansion and include description#25112
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Mar 3, 2025
Merged
Fix tooltip for variable expansion and include description#25112iSazonov merged 2 commits intoPowerShell:masterfrom
iSazonov merged 2 commits intoPowerShell:masterfrom
Conversation
Fixes the tooltip for non-scoped variables to include the type and variable name like it does for scoped variables. Also includes the variable description if present on the variable object.
iSazonov
reviewed
Mar 2, 2025
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with 2 style comment.
(Since it is very small PR you can add descriptions to some system variables where absent if you want.)
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Show resolved
Hide resolved
iSazonov
added
the
CL-General
Co-authored-by: Ilya <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Updated PSES PR so that this will work if merged.
|
1 task
iSazonov
approved these changes
Mar 3, 2025
iSazonov
changed the title
iSazonov
changed the title
Contributor
|
📣 Hey @jborean93, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Collaborator
Author
|
Thanks for the review and merge. |
Contributor
|
Thank you @iSazonov ! |
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes the tooltip for non-scoped variables to include the type and variable name like it does for scoped variables. Also includes the variable description if present on the variable object.
PR Context
It looks like there is a bug where the tooltip was built for a variable but not included in the completion result, this PR makes sure that isn't thrown away.
It also makes a further change to include the variable description if it's present. This may not be used for user variables but there are a few builtin variables where is a description and would be nice to include in the tooltip.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).