Skip to content

Commit 321537c

Browse files
committed
Fix logic and typos.
1 parent 4d0da14 commit 321537c

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/System.Management.Automation/engine/Modules/ModuleSpecification.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,10 @@ internal static Exception ModuleSpecificationInitHelper(ModuleSpecification modu
164164
return new ArgumentException(message);
165165
}
166166

167-
if (moduleSpecification.Version > ModuleCmdletBase.GetMaximumVersion(moduleSpecification.MaximumVersion))
167+
if (moduleSpecification.Version != null && moduleSpecification.MaximumVersion != null &&
168+
moduleSpecification.Version > ModuleCmdletBase.GetMaximumVersion(moduleSpecification.MaximumVersion))
168169
{
169-
message = StringUtil.Format(Modules.ModuleSpecificationMemberIsLessThanOther, "MaximumVersion", "Version");
170+
message = StringUtil.Format(Modules.ModuleSpecificationMemberIsLessThanOther, "MaximumVersion", "ModuleVersion");
170171
return new ArgumentException(message);
171172
}
172173
return null;

test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Describe "Import-Module" -Tags "CI" {
5858
}
5959

6060
It "should throw if 'MaximumVersion' is less than 'Version' when using -FullyQualifiedName parameter" {
61-
{ Import-Module -FullyQualifiedName @{ModuleName = $moduleName; Version = '2.0'; MaximumVersion = '1.0'} } | Should -Throw -ExceptionType 'System.Management.Automation.ParameterBindingException'
61+
{ Import-Module -FullyQualifiedName @{ModuleName = $moduleName; ModuleVersion = '2.0'; MaximumVersion = '1.0'} } | Should -Throw -ExceptionType 'System.Management.Automation.ParameterBindingException'
6262
}
6363
}
6464

0 commit comments

Comments
 (0)