Port clone dsc resource test improvements - #159
Daniel Scott-Raynsford (PlagueHO) merged 4 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #159 +/- ##
===================================
Coverage 83% 83%
===================================
Files 19 19
Lines 2760 2760
Branches 4 4
===================================
Hits 2303 2303
Misses 453 453
Partials 4 4 |
|
Hey Daniel Scott-Raynsford (@PlagueHO) , would you be able to review this when you get a chance? This is a direct port of your fix in XPSDesiredStateConfiguration. Thanks. |
Mike Hendrickson (mhendric)
added
the
needs review
Daniel Scott-Raynsford (PlagueHO)
left a comment
Daniel Scott-Raynsford (PlagueHO)
left a comment
There was a problem hiding this comment.
Cool! Just one minor tweak and we're good to go. Thanks Mike Hendrickson (@mhendric)
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Mike Hendrickson (@mhendric))
Tests/TestHelpers/CommonTestHelper.psm1, line 420 at r1 (raw file):
}
Can you remove these two blank lines? Only one needed.
Mike Hendrickson (mhendric)
left a comment
Mike Hendrickson (mhendric)
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on Daniel Scott-Raynsford (@PlagueHO))
Tests/TestHelpers/CommonTestHelper.psm1, line 420 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Can you remove these two blank lines? Only one needed.
Done. Those two blank lines were in xPSDesiredStateConfiguration too, but I agree that it makes sense to remove them.
da00625 to
612e499
Compare
612e499 to
364bb98
Compare
Daniel Scott-Raynsford (PlagueHO)
left a comment
Daniel Scott-Raynsford (PlagueHO)
left a comment
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Tests/TestHelpers/CommonTestHelper.psm1, line 420 at r1 (raw file):
Previously, mhendric (Mike Hendrickson) wrote…
Done. Those two blank lines were in xPSDesiredStateConfiguration too, but I agree that it makes sense to remove them.
Probably should have corrected it there too 😁 I think we can ignore that for now 😁
3 participants
Pull Request (PR) description
Issue #505
Issue #590
Changes to test helper Enter-DscResourceTestEnvironment so that it only
updates DSCResource.Tests when it is longer than 120 minutes since
it was last pulled. This is to improve performance of test execution
and reduce the likelihood of connectivity issues caused by inability to
pull DSCResource.Tests.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is